Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler error on MSVC with c++latest #3954

Merged
merged 3 commits into from Feb 18, 2022
Merged

Fix compiler error on MSVC with c++latest #3954

merged 3 commits into from Feb 18, 2022

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Feb 17, 2022 •
edited

by @djarek

Pull Request Prelude

Changes Proposed

Issues addressed:
fixes #3947

@EPuncker EPuncker marked this pull request as draft February 17, 2022 19:11
@EPuncker EPuncker marked this pull request as ready for review February 17, 2022 19:29
@EPuncker EPuncker mentioned this pull request Feb 17, 2022
Closed
ranisalt
ranisalt requested changes Feb 17, 2022
View reviewed changes
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are here, please drop std:: from L36 and rename CAPACITY to Capacity

@ranisalt ranisalt changed the title fix #3947 Fix compiler error on MSVC with c++latest Feb 18, 2022
@ranisalt ranisalt merged commit 2e30d7d into master Feb 18, 2022
@ranisalt ranisalt deleted the EPuncker-patch-1-1 branch February 18, 2022 17:07
Znote pushed a commit to Znote/forgottenserver that referenced this pull request Feb 23, 2022
@EPuncker @Znote
Fix compiler error on MSVC with c++latest (otland#3954)
57d6db4
DSpeichert pushed a commit that referenced this pull request May 9, 2022
@EPuncker @DSpeichert
Fix compiler error on MSVC with c++latest (#3954)
a84f1e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DSpeichert DSpeichert DSpeichert approved these changes

@ranisalt ranisalt ranisalt approved these changes

@djarek djarek Awaiting requested review from djarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MSVC][std:c++latest] forgottenserver failed to build with /std:c++latest on MSVC
3 participants
@EPuncker @DSpeichert @ranisalt